-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rarity Filters & Refactoring #2962
Conversation
This seems to consider all available rarities for a card. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MYTHIC RARE: m, mr, mythic rare
One might search for mythic
only too!
That returns no results at the moment.
} | ||
|
||
template <class T> | ||
FilterTreeBranch<T>::~FilterTreeBranch() | ||
{ | ||
while (!childNodes.isEmpty()) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you adjust the style guide and remove the instruction to skip braces for 1-liner blocks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll get around to updating all the files this week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems every new dev skips braces on 1-liners until they discover it leads to errors later. Glad to hear that's not the desired style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went that way originally because it's very nice in scala. Of course scala is expression-oriented so a typical 'missing brace' code error will pretty much always make compiling fail instead of silently being weird. Doesn't make sense for C++
Fixed @tooomm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding that in!
Fixes #2952
This will implement rarity filter updates.
I also refactored the file I was working with as CLion said it was bad... Fixed up the colorless stuff as well so it's more in line with what the filter code written does.
I'll be fixing up contribution docs at some point this month.