Update Rarity Filters & Refactoring #2962
Conversation
|
This seems to consider all available rarities for a card. |
| } | ||
|
|
||
| template <class T> | ||
| FilterTreeBranch<T>::~FilterTreeBranch() | ||
| { | ||
| while (!childNodes.isEmpty()) | ||
| { |
There was a problem hiding this comment.
Can you adjust the style guide and remove the instruction to skip braces for 1-liner blocks?
There was a problem hiding this comment.
I'll get around to updating all the files this week
There was a problem hiding this comment.
It seems every new dev skips braces on 1-liners until they discover it leads to errors later. Glad to hear that's not the desired style.
There was a problem hiding this comment.
Went that way originally because it's very nice in scala. Of course scala is expression-oriented so a typical 'missing brace' code error will pretty much always make compiling fail instead of silently being weird. Doesn't make sense for C++
|
Fixed @tooomm |
Fixes #2952
This will implement rarity filter updates.
I also refactored the file I was working with as CLion said it was bad... Fixed up the colorless stuff as well so it's more in line with what the filter code written does.
I'll be fixing up contribution docs at some point this month.