Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim all inputs (except password) #3018

Merged
merged 2 commits into from
Jan 17, 2018
Merged

Trim all inputs (except password) #3018

merged 2 commits into from
Jan 17, 2018

Conversation

ZeldaZach
Copy link
Member

Related Ticket(s)

This will trim all inputs to the login details except for the password.

@ZeldaZach ZeldaZach requested a review from tooomm January 16, 2018 20:38
@Nightfirecat
Copy link

Will the saved server/username details be trimmed as well, or would they be the same as the given input?

@ZeldaZach
Copy link
Member Author

@Nightfirecat I trim all fields except for passwords. They will save the trimmed versions.

@ctrlaltca ctrlaltca merged commit 7a150c5 into Cockatrice:master Jan 17, 2018
@ZeldaZach ZeldaZach deleted the fix_3016 branch January 20, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daenyth Daenyth Daenyth approved these changes

@tooomm tooomm Awaiting requested review from tooomm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ZeldaZach @Nightfirecat @Daenyth @ctrlaltca