Fix sideboard

[ZeldaZach]

Fix #3022

General code cleanup

[tooomm]

UI improved 👍

Could we remove the red frames around the buttons as long as no deck is loaded too?

[ZeldaZach]

@tooomm No, I can't remove the red borders, sorry. They're hard coded in between red and green; adding another state would be confusing and not worth it imo

[tooomm]

Actually, I'm seeing issues with this build (4a2feff at appveyor).

Can you properly play a game after you load a deck @ZeldaZach ?
I can't draw or move cards and the battlefield is slightly missplaced.

Client Version: 2.5.0-custom(4a2feff) (2018-01-19)
Client Operating System: Windows 10 (10.0)
Build Architecture: 64-bit
Qt Version: 5.9.2
QWindowsWindow::setGeometry: Unable to set geometry 120x30+583+330 on QWidgetWindow/'QInputDialogClassWindow'. Resulting geometry:  195x90+583+330 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 195x90, maximum size: 524287x90).
Adding room: ID= 0 name= ""
Server::loginUser: LocalServerInterface(0x175043a46d0) name= "Player 1"
session id: 0
gameEvent: invalid gameId
Server_AbstractUserInterface::playerAddedToGame(): gameId = 1
GameScene::addPlayer name= "Player 1"
cache fail for "_trice_card_back_274297"
QWindowsWindow::setGeometry: Unable to set geometry 1366x971+0+23 on QWidgetWindow/'MainWindowClassWindow'. Resulting geometry:  1366x705+0+23 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 640x971, maximum size: 16777215x16777215).
cache fail for "_trice_card_back_274204"
Loaded from ".../AppData/Local/Cockatrice/Cockatrice/decks/AKH Pre-Release Deck.cod" - true
Deck was loaded - true
Trying to load picture (set:  "AKH"  card:  "Angel of Sanctions" )
Picture found on disk (set:  "AKH"  file:  "Angel of Sanctions" )
...
Trying to load picture (set:  "AKH"  card:  "Ahn-Crop Crasher" )
Picture found on disk (set:  "AKH"  file:  "Ahn-Crop Crasher" )
addCounter: "Player 1" 0 "life"
addCounter: "Player 1" 1 "w"
addCounter: "Player 1" 2 "u"
addCounter: "Player 1" 3 "b"
addCounter: "Player 1" 4 "r"
addCounter: "Player 1" 5 "g"
addCounter: "Player 1" 6 "x"
addCounter: "Player 1" 7 "storm"
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
cache fail for "_trice_card_back_96136"
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
QPixmap::scaled: Pixmap is a null pixmap
libpng warning: iCCP: known incorrect sRGB profile
libpng warning: iCCP: known incorrect sRGB profile
QPainter::end: Painter ended with 2 saved states
QWindowsWindow::setGeometry: Unable to set geometry 120x30+583+463 on QWidgetWindow/'QInputDialogClassWindow'. Resulting geometry:  178x90+583+463 (frame: 8, 31, 8, 8, custom margin: 0, 0, 0, 0, minimum size: 178x90, maximum size: 524287x90).

Errors like the geometry or card back cache are not new and have been there for a long long time for me btw.