Hide non-existent card values in infowidget and cardframe

[berserkingyadis]

Related Ticket(s)

• Fixes card preview in chat contains empty values #2972

Short roundup of the initial problem

When clicking on a card linked in the chat (or displaying it in the deck editor), it contains emtpy values. For example Power/Toughness for spells or mana cost for lands.

What will change with this Pull Request?

• Empty fields will be hidden in both the Infowidget (clicking on cards from chat) and the Deckeditor
• Cards without color will have the Color string "Colorless"

Screenshots

Before

After

[berserkingyadis]

This is still work in progress, I tried hiding the big card text box (empty for lands for example), but doing so will hide some of the card type text aswell. This may be the result of some fixed/hardcoded pixel values.

[tooomm]

Cards without color will have the Color string "Colorless"

That's also a nice addition! 👍

[berserkingyadis]

What about the CardinfoWidget which opens when clicking a card which does not exist? (Example: [[Gozilla]])

Currently its this

i could change it to this (text hidden, only cardback)

I realize this is not the most optimal solution but it could be done easily.

[ZeldaZach]

Make sure you run the ./clangify.sh at the top level so your code gets formatted correctly! :)

[ZeldaZach]

I also like the idea of having a blank card / nothing show when you hover over a bad card (something that's not found in your local db)

[Daenyth]

I like the idea of having the "card missing" back image showing a label under the card back image showing "unknown card: $name"

[berserkingyadis]

Unknown cards now look like this in the CardInfoWidget

This should be everything, someone please test this. This PR affects the cardframe in the deckbuilder, the cardinfowidget when clicking on a linked card, the cardframe in the game view (when hovering over a card for example) and (dont know if that still is in cockatrice) middle clicking a card in the game view.

[Daenyth]

Awesome! This is really exciting :)

[tooomm]

Gave things a run in the client - I think it all works out as expected! 👍

[Vafthrudnir]

Great changes!
Hadn't had the chance to test it, but code-wise looks correct. 👍

[Daenyth]

@berserkingyadis Thanks so much for the contribution, and congrats on your first merge! :)