-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide non-existent card values in infowidget and cardframe #3239
Hide non-existent card values in infowidget and cardframe #3239
Conversation
This is still work in progress, I tried hiding the big card text box (empty for lands for example), but doing so will hide some of the card type text aswell. This may be the result of some fixed/hardcoded pixel values. |
That's also a nice addition! 👍 |
Make sure you run the |
I also like the idea of having a blank card / nothing show when you hover over a bad card (something that's not found in your local db) |
I like the idea of having the "card missing" back image showing a label under the card back image showing "unknown card: $name" |
Unknown cards now look like this in the CardInfoWidget This should be everything, someone please test this. This PR affects the cardframe in the deckbuilder, the cardinfowidget when clicking on a linked card, the cardframe in the game view (when hovering over a card for example) and (dont know if that still is in cockatrice) middle clicking a card in the game view. |
Awesome! This is really exciting :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave things a run in the client - I think it all works out as expected! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes!
Hadn't had the chance to test it, but code-wise looks correct. 👍
@berserkingyadis Thanks so much for the contribution, and congrats on your first merge! :) |
Related Ticket(s)
Short roundup of the initial problem
When clicking on a card linked in the chat (or displaying it in the deck editor), it contains emtpy values. For example Power/Toughness for spells or mana cost for lands.
![34120202-1c3c75d0-e425-11e7-89d1-f8c9eb152e78](https://user-images.githubusercontent.com/9959527/39940243-e87b1dbe-5558-11e8-8842-c0a99405a650.png)
What will change with this Pull Request?
Screenshots
Before
After