Remove hardcoded path to vc_redist.exe; Fix #3252 #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlaltca
changed the title
Vafthrudnir
approved these changes
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
We bundle the MS visual studio redistributable libraries package (vcredist) inside out windows NSIS package.
The path to the vcredist was hardcoded inside CMakeLists.txt, but it contains the MSVC version number, so every time Visual Studio gets updated the path changes.
What will change with this Pull Request?
The path to vcredist gets deduced dynamically from the path where the basic MSVC libraries are found by cmake.