Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fedora docker image to travis compilation #3447

Merged
merged 11 commits into from
Nov 25, 2018

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Nov 20, 2018

Builds debug and release builds for rpm packages on a fedora docker image within travis.
fixes #1746

@tooomm
Copy link
Member

tooomm commented Nov 20, 2018

Awesome, you made the cache work within docker for Bionic! Quite speeeedy, cool. 😃👍

But I'm wondering if both caches for Fedora 29 and Bionic are conflicting since they are using the same directory and travis only creates caches for each base image.
Here, the base image is the same trusty image, so they fetch from (and write to) the same cache:
Bionic: https://travis-ci.org/Cockatrice/Cockatrice/jobs/457625460#L445
Fedora: https://travis-ci.org/Cockatrice/Cockatrice/jobs/457625461#L445

Our normal Xenial build, uses a different, xenial-tagged cache: https://travis-ci.org/Cockatrice/Cockatrice/jobs/457625459#L987

@ebbit1q
Copy link
Member Author

ebbit1q commented Nov 21, 2018

Interesting, this might explain some stuff

@ebbit1q
Copy link
Member Author

ebbit1q commented Nov 22, 2018

Hey, look at that.

@Cockatrice Cockatrice deleted a comment Nov 22, 2018
@Cockatrice Cockatrice deleted a comment Nov 22, 2018
@Cockatrice Cockatrice deleted a comment from ebbit1q Nov 22, 2018
@Cockatrice Cockatrice deleted a comment Nov 22, 2018
@Cockatrice Cockatrice deleted a comment Nov 22, 2018
@Cockatrice Cockatrice deleted a comment from ebbit1q Nov 22, 2018
@ebbit1q
Copy link
Member Author

ebbit1q commented Nov 23, 2018

image
Works well.

@tooomm
Copy link
Member

tooomm commented Nov 23, 2018

That's pretty cool!

Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@ctrlaltca ctrlaltca merged commit f1563c5 into Cockatrice:master Nov 25, 2018
@ctrlaltca
Copy link
Contributor

Another great addition! Thanks!

@ebbit1q ebbit1q deleted the docker_fedora branch November 25, 2018 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPM Builds
4 participants