Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rpm builds in travis #3472

Merged
merged 2 commits into from
Dec 12, 2018
Merged

fix rpm builds in travis #3472

merged 2 commits into from
Dec 12, 2018

Conversation

ebbit1q
Copy link
Member

@ebbit1q ebbit1q commented Dec 12, 2018 •
edited by tooomm

Related Ticket(s)

Short roundup of the initial problem

Fedora builds in travis create debian packages instead of rpm ones (added in #3447)

What will change with this Pull Request?

  • the correct argument will be passed to cmake
  • the missing dependency will be added to the image file

ctrlaltca
ctrlaltca approved these changes Dec 12, 2018
View reviewed changes
Copy link
Contributor

@ctrlaltca ctrlaltca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but we can't test the produced package until this gets merged.

@ebbit1q
Copy link
Member Author

ebbit1q commented Dec 12, 2018

I tested it on fedora, the package works.

@ctrlaltca ctrlaltca merged commit cee6970 into Cockatrice:master Dec 12, 2018
@tooomm
Copy link
Member

tooomm commented Dec 12, 2018

rpm deployment worked 👍

@ebbit1q ebbit1q deleted the rpmbuild branch December 12, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlaltca ctrlaltca ctrlaltca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ebbit1q @tooomm @ctrlaltca