Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pics for Unknown Cards #3589

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Conversation

basicer
Copy link
Member

@basicer basicer commented Feb 23, 2019

Short roundup of the initial problem

  • If you see a card name you don't have in your database, it is always blank.

What will change with this Pull Request?

If the user has pic templates that could support it, try to download pictures for unknown cards.

- If a CardInfo has no sets, add a dummy one to try to download it by non-set specific templates.
Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just tested and this is great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants