Dont create dummy card infos for unkown cards #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Short roundup of the initial problem
The change in #3589 added the ability to retrieve a card picture even if the card is not present in the card database, by creating an empty card info (aka a card database entry) for these cards.
A good use case is during a game, when we receive from the server a card name of a card that another player put on the game but that is not present in our card database.
We can still create a dummy card info with just the card name and try to get a picture for it.
Unfortunately the empty card info is created also for card that are unknown "by design", eg. facedown cards in a player's deck. These cards can be easily recognized by the fact that they have no name and a server id of -1.
What will change with this Pull Request?
The dummy card info won't be created if the name is empty.
This restores the old behavior where the card back is shown.