Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3068: Add hint text about game list filters #3946

Merged
merged 2 commits into from
Apr 7, 2020

Conversation

knitknit
Copy link
Contributor

@knitknit knitknit commented Apr 7, 2020

Related Ticket(s)

Short roundup of the initial problem

Cockatrice remembers filters applied between sessions, but users were not alerted if any filters were altered from their default values.

What will change with this Pull Request?

  • Display hint text next to former "Clear filters" button, indicating either that default filters are applied or that filters have been altered from default values.
  • Rename "Clear filters" to "Reset filters", but keep 'l' as the hotkey. This seems like a more accurate name, as we're not actually clearing all filters (for example, "show password protected games" is true by default and therefore checked in the UI).

Screenshots

Hint text on initial load, assuming filters are set to default:

default-start

Hint text after altering filters:

applied

Hint text after resetting filters:

reset

Copy link
Member

@ZeldaZach ZeldaZach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm super happy with this pr! Thanks for your contribution. I hope you choose to stick around a bit :)

Reach us anytime on Gitter or Discord!

@ZeldaZach ZeldaZach merged commit 2c3eab9 into Cockatrice:master Apr 7, 2020
@knitknit
Copy link
Contributor Author

knitknit commented Apr 8, 2020

Woohoo! Happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add text hint that filter are applied to the game list
2 participants