Change filter hint text to "Games shown: X / Y" and fix user-game segfault

[knitknit]

Related Ticket(s)

• Fixes Add text hint that filter are applied to the game list #3068 (reverts Fix #3068: Add hint text about game list filters #3946)
• Fixes Cockatrice segfaults when viewing another user's games #3979 (crash caused in Fix #3068: Add hint text about game list filters #3946)
• Makes Game filter hint not working correctly #3957 less obvious to users (though I think there's still something wrong there)

Short roundup of the initial problem

Cockatrice remembers filters applied between sessions, but users were not alerted if any filters were altered from their default values.

What will change with this Pull Request?

• Revert Fix #3068: Add hint text about game list filters #3946
• Instead, change the hint text to read "Games shown: 13 / 42"
• Update hint text on interesting events, like games being added or newly meeting/not meeting filter criteria
• Fix segfault that occurred when viewing user's games

Screenshots

Screenshot of "Games shown" text:

Screenshot of viewing user's games, client did not crash before/during/after:

[knitknit]

@tooomm @ZeldaZach this appears to work the way I would expect, though I'm wondering if there's a more efficient way to do it?

Once we agree on general approach, I'll wire in the changes to also update the hint text as the game list is updated, if we want to. Thanks!

[ebbit1q]

Still crashes when trying to view a user's games, did you test this locally? You can follow the steps in #3979 to reproduce.

[knitknit]

Still crashes when trying to view a user's games, did you test this locally? You can follow the steps in #3979 to reproduce.

So strange! I just brought up a fresh build with the change again and I don't see it crashing. Maybe this is a difference between Mac and Windows?

Just to make sure we're talking about the same thing - what do you mean by crash? I assume the client totally freezes and/or exits out? Or does it appear fine to a user but show errors in a console somewhere? (Sorry if these are silly questions, still a new contributor.)

[ebbit1q]

There are no silly questions, by crash I mean it segfaults the same as in the linked ticket I made, anyway I must have messed up building (probably was still on master) because I built it again and it now works fine.

[ebbit1q]

This looks great!

[tooomm]

Will finally get around to check this later today, sorry. 🙈

[ebbit1q]

Travis finished but doesn't update on github https://travis-ci.org/github/Cockatrice/Cockatrice/builds/683312387

This is really annoying cus it blocks merge

[knitknit]

Travis finished but doesn't update on github https://travis-ci.org/github/Cockatrice/Cockatrice/builds/683312387

This is really annoying cus it blocks merge

Anything I can help with from my end to re-run or update it?

[ebbit1q]

No, this is an issue with our ci system that automatically validates pull requests, if someone else tests this pr to work well I'll instead merge it manually circumventing the web interface.

[tooomm]

Hmm, this took me a while as I'm still not sure what (or how) to write (it) exactly...

First things first:
The feature seems to work and I prefer this over the initial approach in #3946. 👍
I also can no longer crash the client. 😄

Note: This PR adds the counter of currently visible/shown games requested in #583 and extends it for the number of total games in this specific room on the server. With a different location to display it. :)

But...
I created the requesting issue (#3068) with the problem in mind, that a user should quickly & easily know once default filters are altered. I realized that I worded that not ideal as I also wrote "clarify to the user that the game list doesn't show all available games" next to its title and the quote.

To wrap it up - what this PR basically does

• Show number of displayed games
• Show number of total games in this room (not on all server, which is good!)
• Clear filter button is disabled after click (👍)

What this PR doesn't

From this PR description:

Short roundup of the initial problem

Cockatrice remembers filters applied between sessions, but users were not alerted if any filters were altered from their default values.

I'm still pretty sure - even with this PR - users don't know if default filters do apply or if they are altered. Maybe I'm completely overlooking something here?
Showing all existing games /= default filter settings!
Most of the created games are not relevant to the user normally as they are already running/filled up (=unavailable games). Hence they are not shown on default.
Only hitting the clear button indicates the user that default values are used, because it disables the button. On the other hand, setting default values manually still shows the button active...

What to do with this PR now? It still adds a nice value to the client.

I propose to also disable the Clear filter button if filters set by hand do match default values.
Additionally, IMO the ideal solution would be to move the game count to the headline above the game list (fixes #583), and just show a simple text hint next to the filter buttons once default is altered.
Maybe such a hint can completely be skipped as long as the clear button is consistently disabled on default filter setting! Also, the current location to show the game count is not necessarily worse - I just like the headline more for consistency reasons.

Thoughts?

[ebbit1q]

The main issue this addresses is the people complaining about not seeing any games going on. I'd like the amount of games shown in the ui somewhere merged as quickly as possible. The reset filter button behavior can be split off if need be.

[ZeldaZach]

Overall this makes me happy, and i'd like to ship it as-is. If there are changes to be made in the future, that can happen.

[knitknit]

Sounds good, thanks all! @tooomm feel free to reopen and assign #3068 to me and we can discuss the idea of default filters there, if we'd like to tweak it?