Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift_support branch fails to compile with cocoapods - can't find Classes/CocoaLumberjack.modulemap #531

Closed
mattlilek opened this issue Jun 15, 2015 · 3 comments
Labels
Milestone

Comments

@mattlilek
Copy link

My iOS project has cocoalumberjack configured to track the swift_support branch without locking to a specific commit (bad, I know). I discovered it was failing this morning, unable to find Classes/CocoaLumberjack.modulemap (you can also see this by running pod lib lint from within the CocoaLumberjack repo).

It looks like when #525 was merged into swift_support in fb70080, a couple of commits might have gotten lost along the way, specifically bd4d756 and ae92aea. Cherry-picking those seems to get things going farther.

Not sure if anything else got lost along the way or if something else is going on here, otherwise I'd just submit a PR.

@sebromero
Copy link

+1 Just discovered that as well. I will stick to commit 9b31277 meanwhile.

@rivera-ernesto
Copy link
Member

Yes please do submit a pull request while we find out why commits got lost.

@bpoplauschi bpoplauschi added this to the 2.1.0 - Swift milestone Jun 24, 2015
bpoplauschi added a commit that referenced this issue Jun 24, 2015
…o the Framework/Lumberjack folder and the podspec path was not updated

Fixed `pod lib lint` by creating a separate subspace Swift that has the deployment targets iOS8 and OS X 10.10. If has to depend on the Extensions subspec as the modulemap references those files.
The error with the old podspec was "Swift support uses dynamic frameworks and is therefore only supported on iOS > 8."
@bpoplauschi
Copy link
Member

@mattlilek sorry for this, there was an issue with the modulemap being moved and the podspec was not updated with this new path. Also, I fixed another issue that was causing pod lib lint to fail.
Please not that now you have to work with the Swift subspec. All the details are here: af40293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants