Cleanup

[diederich]

New Pull Request Checklist

• I have read and understood the CONTRIBUTING guide

• I have read the Documentation

• I have searched for a similar pull request in the project and found none

• I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

• [n/a] I have added the required tests to prove the fix/feature I am adding

• [n/a] I have updated the documentation (if necessary)

• I have run the tests and they pass

• I have run the lint and it passes (pod lib lint)

Pull Request Description

I just enabled CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER in one of our projects and got some warnings from Lumberjack. This PR gets rid of them.
Also, it fixes an Xcode 10.2 warning about development region not being in the right format.

[ffried]

LGTM

[ffried]

@diederich Should we enable this warning (CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER) also for this project to catch such errors sooner?

[diederich]

@ffried

Should we enable this warning (CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER) also for this project to catch such errors sooner?

Oh, yeah, good call. Let me try...

[diederich]

@ffried Yep, excellent call. Found a few more with that enabled :-)

[OSSPolice]

	2 Warnings
⚠️	The library files were changed, but the tests remained unmodified. Consider updating or adding to the tests to match the library changes.
⚠️	The Carthage project was modified but CocoaPods podspec wasn’t. Did you forget to update the podspec?

Generated by 🚫 Danger

[codecov-io]

Codecov Report

Merging #1059 into master will decrease coverage by 0.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1059      +/-   ##
==========================================
- Coverage   39.47%   38.94%   -0.53%     
==========================================
  Files          27       27              
  Lines        4018     4018              
==========================================
- Hits         1586     1565      -21     
- Misses       2432     2453      +21

Impacted Files	Coverage Δ
Classes/DDLog.h	88.23% <ø> (ø)	⬆️
Classes/DDTTYLogger.h	0% <ø> (ø)	⬆️
Classes/Extensions/DDDispatchQueueLogFormatter.h	0% <ø> (ø)	⬆️
Classes/DDFileLogger.h	83.33% <ø> (ø)	⬆️
Classes/Extensions/DDFileLogger+Buffering.m	79.16% <ø> (ø)	⬆️
Classes/DDASLLogger.m	13.46% <0%> (-42.31%)	⬇️
Classes/DDFileLogger.m	58.48% <0%> (-0.13%)	⬇️
Classes/DDOSLogger.m	65.38% <0%> (+3.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c64566...eb90e3c. Read the comment docs.

[ffried]

@diederich Looks good, thanks! One small thing: Can you update the CHANGELOG with a point in the internal section mentioning your change?