-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #1059
Cleanup #1059
Conversation
use the correct specifier `en` instead of `English`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@diederich Should we enable this warning ( |
Oh, yeah, good call. Let me try... |
@ffried Yep, excellent call. Found a few more with that enabled :-) |
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 39.47% 38.94% -0.53%
==========================================
Files 27 27
Lines 4018 4018
==========================================
- Hits 1586 1565 -21
- Misses 2432 2453 +21
Continue to review full report at Codecov.
|
@diederich Looks good, thanks! One small thing: Can you update the CHANGELOG with a point in the internal section mentioning your change? |
New Pull Request Checklist
I have read and understood the CONTRIBUTING guide
I have read the Documentation
I have searched for a similar pull request in the project and found none
I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)
[n/a] I have added the required tests to prove the fix/feature I am adding
[n/a] I have updated the documentation (if necessary)
I have run the tests and they pass
I have run the lint and it passes (
pod lib lint
)Pull Request Description
I just enabled
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER
in one of our projects and got some warnings from Lumberjack. This PR gets rid of them.Also, it fixes an Xcode 10.2 warning about development region not being in the right format.