Declare automaticallyAppendNewlineForCustomFormatters properties as nonatomic #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In both cases that were found, the property does not need to be atomic as they are boolean flags.
It is possible, though unlikely, that a DDTTYLogger instance will have its _automaticallyAppendNewlineForCustomFormatters property changed between the first and second checks of the value within a single message logging. Going from a NO to YES configuration will cause stack corruption.
| @@ -1247,7 +1247,7 @@ - (void)logMessage:(DDLogMessage *)logMessage { | |||
| v[2].iov_base = (char *)msg; | |||
| v[2].iov_len = msgLen; | |||
|
|
|||
| if (_automaticallyAppendNewlineForCustomFormatters) { | |||
| if (iovec_len == 5) { | |||
There was a problem hiding this comment.
So _automaticallyAppendNewlineForCustomFormatters is now simply ignored?
There was a problem hiding this comment.
It is not ignored, _automaticallyAppendNewlineForCustomFormatters was checked a few lines above the diff context shown here (https://github.com/Marketcircle/CocoaLumberjack/blob/274842595742f649c5c67368c5f46584e4142688/Classes/DDTTYLogger.m#L1224). _automaticallyAppendNewlineForCustomFormatters was used to decide how large the io_vec should be.
Without this change, checking _automaticallyAppendNewlineForCustomFormatters again here causes a potential race condition if the property is changed from @NO to @YES.
rivera-ernesto
pushed a commit
that referenced
this pull request
Feb 2, 2015
Declare automaticallyAppendNewlineForCustomFormatters properties as nonatomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were implicitly atomic and do not need to be. Noticed this in a project where the relevant warnings were enabled.