Tests for DDLogmessage #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Ernesto, this one won't actually build in Travis until the #499 is merged in. I wrote the tests to comply with the documentation in the DDLogMessage so it must fail. Two errors actually where I check file & function attributes copy behaviour. I think I need to figure out why the #499 is failing first, fix that and then merge this one in. |
|
Thanks @pk for all the unit tests you created and sorry for the delay of adding them into the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi from Cocoapods TestJam,
I'm trying to add some test coverage for the project. Started with the DDLogMessage as it was simple enough.
There are 2 failing tests because I've wrote tests according to the documentation which mentions using DDLogMessageOptions to force copy the file & function strings but the code is actually missing in the implementation.