Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous access to currentLogFileHandle. #946

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Synchronous access to currentLogFileHandle. #946

merged 1 commit into from
Sep 11, 2018

Conversation

sushichop
Copy link
Member

New Pull Request Checklist

  • I have read and understood the CONTRIBUTING guide

  • I have read the Documentation

  • I have searched for a similar pull request in the project and found none

  • I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)

  • I have added the required tests to prove the fix/feature I am adding
    --> Instead, I tested several times manually at local machine.

  • I have updated the documentation (if necessary)

  • I have run the tests and they pass

  • I have run the lint and it passes (pod lib lint)

This merge request fixes / refers to the following issues: #945

Pull Request Description

I added synchronous access to currentLogFileHandle.

@codecov-io
Copy link

Codecov Report

Merging #946 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
- Coverage   22.31%   22.22%   -0.09%     
==========================================
  Files          17       17              
  Lines        2631     2641      +10     
==========================================
  Hits          587      587              
- Misses       2044     2054      +10
Impacted Files Coverage Δ
Classes/DDFileLogger.m 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9d6971...d9760f4. Read the comment docs.

@rivera-ernesto rivera-ernesto merged commit 42ea724 into CocoaLumberjack:master Sep 11, 2018
@bpoplauschi
Copy link
Member

Thanks @sushichop

@bpoplauschi bpoplauschi added this to the 3.4.3 milestone Sep 11, 2018
@sushichop sushichop deleted the PR/sync-filehandle branch September 12, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants