Merge pull request #62 from CocoaPods/seg-rubocop-0.38

[Bundle] Update RuboCop

.rubocop.yml

@@ -1,2 +1,3 @@
 inherit_from:
- - .rubocop_cocoapods.yml
+  - .rubocop_todo.yml
+  - .rubocop_cocoapods.yml

.rubocop_cocoapods.yml

@@ -5,6 +5,7 @@ AllCops:
     - ./*.gemspec
   Exclude:
     - ./spec/fixtures/**/*
+    - ./vendor/bundle/**/*
 
 # At the moment not ready to be used
 # https://github.com/bbatsov/rubocop/issues/947
@@ -39,7 +40,10 @@ Encoding:
 
 # Having these make it easier to *not* forget to add one when adding a new
 # value and you can simply copy the previous line.
-TrailingComma:
+Style/TrailingCommaInArguments:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInLiteral:
   EnforcedStyleForMultiline: comma
 
 Style/MultilineOperationIndentation:
@@ -58,6 +62,11 @@ Next:
 Metrics/ClassLength:
   Enabled: false
 
+# Arbitrary max lengths for modules simply do not work and enabling this will
+# lead to a never ending stream of annoyance and changes.
+Metrics/ModuleLength:
+  Enabled: false
+
 # Arbitrary max lengths for methods simply do not work and enabling this will
 # lead to a never ending stream of annoyance and changes.
 Metrics/MethodLength:
@@ -77,6 +86,11 @@ Metrics/AbcSize:
 Metrics/CyclomaticComplexity:
   Enabled: false
 
+# It will be obvious which code is complex, Rubocop should only lint simple
+# rules for us.
+Metrics/PerceivedComplexity:
+  Enabled: false
+
 #- CocoaPods support for Ruby 1.8.7 ------------------------------------------#
 
 HashSyntax:
@@ -101,6 +115,10 @@ AmbiguousRegexpLiteral:
   Exclude:
     - spec/**/*
 
+Performance/RedundantMatch:
+  Exclude:
+    - spec/**/*
+
 # Allow `object.should == object` syntax.
 Void:
   Exclude:
@@ -113,4 +131,3 @@ ClassAndModuleChildren:
 UselessComparison:
   Exclude:
     - spec/**/*
-

.rubocop_todo.yml

@@ -0,0 +1,70 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-03-09 18:40:14 -0600 using RuboCop version 0.38.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 3
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'lib/claide/command.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Lint/UnneededDisable:
+  Exclude:
+    - 'spec/command/banner_spec.rb'
+
+# Offense count: 1
+Performance/FixedSize:
+  Exclude:
+    - 'lib/claide/command/banner.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/StringReplacement:
+  Exclude:
+    - 'lib/claide/command/banner.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: prefer_alias, prefer_alias_method
+Style/Alias:
+  Exclude:
+    - 'lib/claide/argument.rb'
+    - 'lib/claide/command.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: SingleLineConditionsOnly.
+Style/ConditionalAssignment:
+  Exclude:
+    - 'lib/claide/command/banner.rb'
+
+# Offense count: 1
+Style/IfInsideElse:
+  Exclude:
+    - 'lib/claide/command.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Exclude:
+    - 'lib/claide/ansi.rb'
+    - 'lib/claide/argument.rb'
+    - 'lib/claide/command.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/ParallelAssignment:
+  Exclude:
+    - 'lib/claide/command/argument_suggester.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/UnneededInterpolation:
+  Exclude:
+    - 'lib/claide/command/argument_suggester.rb'

Gemfile.lock

@@ -7,8 +7,6 @@ GEM
   remote: https://rubygems.org/
   specs:
     ast (2.2.0)
-    astrolabe (1.3.0)
-      parser (>= 2.2.0.pre.3, < 3.0)
     bacon (1.2.0)
     codeclimate-test-reporter (0.4.1)
       simplecov (>= 0.7.1, < 1.0.0)
@@ -32,28 +30,29 @@ GEM
     notify (0.5.2)
     parser (2.3.0.6)
       ast (~> 2.2)
-    powerpack (0.1.0)
+    powerpack (0.1.1)
     prettybacon (0.0.2)
       bacon (~> 1.2)
-    rainbow (2.0.0)
+    rainbow (2.1.0)
     rake (10.3.2)
     rb-fsevent (0.9.4)
     rb-inotify (0.9.5)
       ffi (>= 0.5.0)
     rb-kqueue (0.2.3)
       ffi (>= 0.5.0)
-    rubocop (0.29.1)
-      astrolabe (~> 1.3)
-      parser (>= 2.2.0.1, < 3.0)
+    rubocop (0.38.0)
+      parser (>= 2.3.0.6, < 3.0)
       powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.4)
-    ruby-progressbar (1.7.1)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.7.5)
     simplecov (0.9.1)
       docile (~> 1.1.0)
       multi_json (~> 1.0)
       simplecov-html (~> 0.8.0)
     simplecov-html (0.8.0)
+    unicode-display_width (1.0.1)
 
 PLATFORMS
   ruby

lib/claide/command/argument_suggester.rb

@@ -81,8 +81,6 @@ def self.prettify_suggestion(suggestion, argument_type)
       #         The second string to compare.
       #
       # @return [Fixnum] The distance between the strings.
-      #
-      # rubocop:disable all
       def self.levenshtein_distance(a, b)
         a, b = a.downcase, b.downcase
         costs = Array(0..b.length)
@@ -96,7 +94,6 @@ def self.levenshtein_distance(a, b)
         end
         costs[b.length]
       end
-      # rubocop:enable all
     end
   end
 end

spec/command/banner_spec.rb

@@ -243,7 +243,6 @@ class Banner
           TextWrapper.wrap_formatted_text(string, 0, 20).should == result
         end
 
-        # rubocop:disable all
         it 'handles multi-line code blocks regarding indentation' do
           string = <<-DOC.strip_margin('|').rstrip
             |Examples:
@@ -262,7 +261,6 @@ class Banner
           DOC
           TextWrapper.wrap_formatted_text(string, 2, 20).should == result
         end
-        # rubocop:enable all
       end
 
       describe '::wrap_with_indent' do