Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansi simplification #24

Closed
wants to merge 3 commits into from
Closed

Conversation

fabiopelosin
Copy link
Member

@alloy What do you think of this?

@alloy
Copy link
Member

alloy commented May 9, 2014

I like it. Although I do wonder about using two different files for this, because you can only override the setting once in that case (if the user ever needs to change the setting). Why not one String#ansi method that based on a global setting returns a stub or a real ansi-fied string?

@fabiopelosin
Copy link
Member Author

What about this solution?

@alloy
Copy link
Member

alloy commented May 9, 2014

Perfetto!

@fabiopelosin
Copy link
Member Author

Ace!

@fabiopelosin fabiopelosin deleted the ansi-simplification branch May 9, 2014 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants