Skip to content
This repository has been archived by the owner on Nov 3, 2020. It is now read-only.

Added Open button on Home Window for empty Recent list #185

Merged
merged 3 commits into from
Jan 13, 2016

Conversation

wrutkowski
Copy link
Contributor

Sketch assets included + source of the icon included

@wrutkowski
Copy link
Contributor Author

As per #180 task 3 and #174.

BTW Is there a better/another way to include graphics assets and contribution/sources to the project?

@orta
Copy link
Member

orta commented Jan 13, 2016

I've been keeping all design related stuff in - https://github.com/cocoapods/design it's a pretty reasonable way to do it since LayerVault closed down

@orta
Copy link
Member

orta commented Jan 13, 2016

Leaving this to PR to @mennenia

@mennenia
Copy link
Collaborator

Having a look! :)

@wrutkowski
Copy link
Contributor Author

Ok, I'll make PR with assets to that repo then. Thanks.

@mennenia
Copy link
Collaborator

Cool! So I had a look - awesome work, cheers!

Could we make the icon and the text the same colour? And maybe add a bit more margin between the two as it's quite close? (thinking + 5 or + 10 even

screen shot 2016-01-13 at 21 02 20

Lastly, the icon came from here: http://www.sketchappsources.com/free-source/546-sketch-icons-freebie-resource.html

I've been trying to work out what the license is on those. It's looking like "free is free", but it may be better to go with a freshly made icon. I can export the one I made for the illustrated point in #174.

@mennenia
Copy link
Collaborator

Want to give these a go?

openDocIcons.zip

Also, the colour of the outlines are:

normal: #d9d9d9 or rgb 217
selected: #c0c0c0 or rgb 192

so the text can match them :).

edit

adding a preview of the icons here:

opendocument 2x opendocumentselected 2x

@wrutkowski
Copy link
Contributor Author

Sure, it would be even better with your icon. You can find current assets here: https://github.com/CocoaPods/Design/tree/master/mac-app
I'll change to yours when ready and I'll make that margin bigger.
Text color is #aaaaaa / rgb(170, 170, 170), selected #555555 / rgb(85, 85, 85)

@wrutkowski
Copy link
Contributor Author

Hah, thanks. I'll match the text to your colours then.

@mennenia
Copy link
Collaborator

Let's see how it looks, if all ok, I'll make sure to add it to the CP design repo :)!

Thanks again ^_^!

…ncreased space between elements. Changed button contraints so that it can fit longer texts (translations).
@wrutkowski
Copy link
Contributor Author

@mennenia done :)

@mennenia
Copy link
Collaborator

Awesome, looks great. Loving the extra padding especially :).

I'll wait for the checks to be done and then we can merge!

mennenia added a commit that referenced this pull request Jan 13, 2016
Added Open button on Home Window for empty Recent list
@mennenia mennenia merged commit 992f5f8 into CocoaPods:master Jan 13, 2016
@mennenia mennenia mentioned this pull request Jan 16, 2016
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants