Merge pull request #403 from siuying/validate_platform

raise informative error message when user supplied invalid platform
CocoaPods · Jul 15, 2012 · cae31b0 · cae31b0
2 parents 09ebfb1 + 695509f
commit cae31b0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/cocoapods/podfile.rb b/lib/cocoapods/podfile.rb
@@ -199,6 +199,8 @@ def platform(name, target = nil)
           target = '4.3'
         when :osx
           target = '10.6'
+        else
+          raise Informative, "Unsupported platform: platform must be one of [:ios, :osx]"
         end
       end
       @target_definition.platform = Platform.new(name, target)

diff --git a/spec/unit/podfile_spec.rb b/spec/unit/podfile_spec.rb
@@ -16,6 +16,12 @@
     podfile.target_definitions[:default].platform.deployment_target.should == Pod::Version.new('4.3')
   end
 
+  it "raise error if unsupported platform is supplied" do
+    lambda {
+      Pod::Podfile.new { platform :iOS }
+    }.should.raise(StandardError, "Unsupported platform")
+  end
+
   it "adds dependencies" do
     podfile = Pod::Podfile.new { pod 'ASIHTTPRequest'; pod 'SSZipArchive', '>= 0.1' }
     podfile.dependencies.size.should == 2