-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify supported locales in a Podfile
#1301
Comments
Afaik, this is only because Appirater adds all those localization bundles in the root of your app’s bundle. It should not do that. It should have a namespaced resource bundle that contains them and adjust the code accordingly. As it is now, you can’t even have your own localizations without merging them with those of Appirater, which is bad. |
So please raise this issue with the lib author. |
@alloy Thanks, that makes more sense. For the curious, I opened arashpayan/appirater#129. |
@eager I would leave out the “When using Appirater via CocoaPods” part and the conditional code to support to the current way, because this issue always applies, so it’s never the right thing to do. |
Podification of the AppXperience Framework
Our project currently only supports one locale (
en
), but we use a pod, Appirater, which supports many (26 at this writing). The App Store infers your app’s localizations by looking at thelproj
bundles, so our app is listed as supporting all 26 locales, when the majority of our app does not.Our current plan is to work around this by using a
pre_install
hook in our Podfile:This is hacky, and not without issues. For example, because we are modifying the filesystem, rather than the generated Xcode project, if we later add a new localization, the
Pods/
directory will need to be deleted and re-installed in order to have access to a pod’s correspondinglproj
.Before resorting to
find(1)
, I looked atInstallerRepresenation
to see if it was possible to iterate over the pods and their resources, but it looks like only source files are exposed. Even resources were exposed, it seems like a better approach might be to extendspec.resource_bundles
to support localizations, and include supported locales in a more formal manner in thePodfile
specification.The text was updated successfully, but these errors were encountered: