[SourcesManager] Ignore repos with unreachable sources on update #1595
Conversation
| # | ||
| def git_remote_reachable?(dir) | ||
| Dir.chdir(dir) { `git ls-remote` } | ||
| $?.exitstatus.zero? |
There was a problem hiding this comment.
Not sure why the method below was using backticks, but this method and the one below should preferably be using the git! method, which also raises a proper error message if the command does not exist.
Finally, but just an FYI, for the exit status you can also use $?.success?.
There was a problem hiding this comment.
$?.success?Ah I didn't know about this one!
There was a problem hiding this comment.
@alloy I'll convert all of them over then. Also good to know about the $?.success? thing
There was a problem hiding this comment.
So it turns out using git! will not throw a fatal with ls-remote if there is no source. Using backticks lets this filter through to the console and not explode. Similarly, using git! for the lower command doesn't seem to work.
There was a problem hiding this comment.
FYI: The executable module implements some logic about this:
git!raises if the exit code is not 0 (it is intended to abort on unexpected failures for subprocesses).gitdoesn't raise (intended to be used in cases where we are checking for a failure).
There was a problem hiding this comment.
Ahhh that makes a ton more sense. I'll try that again.
Conflicts: CHANGELOG.md
|
That failure sometimes happens on Travis and I'm still not able to understand the cause. I have restarted the build which usually is enough to fix it. |
[SourcesManager] Ignore repos with unreachable sources on update
Fixes #1571. We now will ignore all repo's that have unreachable remotes when updating repos.