Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Subspecs in search results with --subspecs #164

Closed
D1plo1d opened this issue Mar 13, 2012 · 7 comments
Closed

Include Subspecs in search results with --subspecs #164

D1plo1d opened this issue Mar 13, 2012 · 7 comments
Assignees
Milestone

Comments

@D1plo1d
Copy link

D1plo1d commented Mar 13, 2012

Given that we need to install subspecs for RestKit it would be nice to have those subspecs show up in the search results under Restkit perhaps via a subspecs option.

Current Functionality

$ pod search restkit

==> RestKit (0.9.3)
    RestKit is a framework for consuming and modeling RESTful web resources on iOS and OS X.

Feature Request / Expected Functionality

$ pod search restkit --subspecs

==> RestKit (0.9.3)
    RestKit is a framework for consuming and modeling RESTful web resources on iOS and OS X.'

    Sub Specs:
    - RestKit/Network
    - RestKit/ObjectMapping
    - RestKit/ObjectMapping/JSONKit
    - RestKit/ObjectMapping/XML
    - RestKit/ObjectMapping/CoreData

Oh and if anyone knows why pod install wouldn't be able to find the RestKit CoreData subspec ( dependency 'RestKit/ObjectMapping/CoreData' ) I am bashing my head against that atm and would appreciate any hints in the direction of a fix (this feature request is a product of that particular PEBKAC I'm experiencing atm).

Edit I figured out that CoreData is a very recent addition to the RestKit spec (ie. > 0.5.1 which I currently have installed). Ugh..
2nd Edit no wait.. thats the Specs repo.. it should be up to date locally.. umm.. wut??

@alloy
Copy link
Member

alloy commented Mar 14, 2012

Good suggestion! I have also created a ticket about it for cocoapods.org.

@alloy
Copy link
Member

alloy commented Mar 14, 2012

Regarding your issue with RestKit/ObjectMapping/CoreData, is your spec repo up-to-date? I.e. do you see the subspec in ~/.cocoapods/master/RestKit/0.9.3/RestKit.podspec? And what's the output of running pod install --verbose?

@alloy
Copy link
Member

alloy commented Mar 18, 2012

@yas375 Do you feel like tackling this one too?

@alloy
Copy link
Member

alloy commented Mar 18, 2012

However, let's leave the --subspecs option away for now and just always include sub specs, there aren't that many yet.

@alloy
Copy link
Member

alloy commented Mar 18, 2012

This code should move into the Specification class.

@ghost ghost assigned yas375 Mar 18, 2012
@yas375
Copy link
Contributor

yas375 commented Mar 18, 2012

Ok, I'll do this next few days)
thanks for tip ;)

@fabiopelosin
Copy link
Member

@yas375 Hey as I've refactored the search command I just wanted to point out that I think set_present.rb#L36 is a good place for this feature. By the way, if you manage to come up with a better name for the module, please change it :-)

@yas375 yas375 closed this as completed Apr 15, 2012
fabiopelosin added a commit that referenced this issue Apr 16, 2012
* origin/master:
  removed exception catching in recursive_subspecs
  one more addition improvement in error_report
  removed extra `if @stats` check in presenter
  imroved project_podfile existence check
  added subspecs into pod presenter [#164]
  fix typo in deprecation warning on config.osx? method
  Added magic comment for utf-8 encoding to spec.rb
  Fixed spec and other minor fixes for pod spec create
  GitHub support for pod spec create
  Draft for spec create from GitHub

Conflicts:
	Gemfile
	Gemfile.lock
	lib/cocoapods/command/error_report.rb
jzapater pushed a commit to jzapater/CocoaPods that referenced this issue Sep 17, 2013
Update SSKeychain and SSZipArchive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants