Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After using Open3 from the doc generator, check the exit status. #180

Closed
alloy opened this issue Mar 19, 2012 · 5 comments
Closed

After using Open3 from the doc generator, check the exit status. #180

alloy opened this issue Mar 19, 2012 · 5 comments
Assignees
Labels
t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Milestone

Comments

@alloy
Copy link
Member

alloy commented Mar 19, 2012

Currently when appledoc fails, for instance because the templates haven't been installed in ~/Library/Application Support/appledoc, there's no error raised that notifies the user of this.

@fabiopelosin
Copy link
Member

There is an issue Using popen3 ruby 1.8 don't have a way to know the exit status because double fork is used. Originally I tried to check for the exit status but I desisted for this reason.

Some solutions my be:

  • check if the standard error is empty
  • the POpen4 gem could solve the issue.

@alloy
Copy link
Member Author

alloy commented Mar 19, 2012

Ah crap, that issue again… :) Yeah we should go with popen4 I think.

It’s actually even worse, because iirc the way the double fork works means that child processes can become zombies.

@ghost ghost assigned fabiopelosin Mar 20, 2012
@fabiopelosin
Copy link
Member

Ok I'll take care of it when a decision is taken about #175.

@fabiopelosin
Copy link
Member

I used popen4.

@alloy
Copy link
Member Author

alloy commented Mar 22, 2012

Sweet.

fabiopelosin added a commit that referenced this issue Mar 22, 2012
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
  [#112] Refactoring based on suggestions by @alloy
  [#112] Improved remote url detection for spec repo
  [#132, #183] Fix to make repo update tolerant of stray files ~./cocoapods
  [#112] Introduced --push option for setup command
fabiopelosin added a commit that referenced this issue Mar 22, 2012
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
jzapater pushed a commit to jzapater/CocoaPods that referenced this issue Sep 17, 2013
fabiopelosin added a commit that referenced this issue Oct 25, 2014
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
  [#112] Refactoring based on suggestions by @alloy
  [#112] Improved remote url detection for spec repo
  [#132, #183] Fix to make repo update tolerant of stray files ~./cocoapods
  [#112] Introduced --push option for setup command
fabiopelosin added a commit that referenced this issue Oct 25, 2014
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
segiddins added a commit that referenced this issue Oct 25, 2014
[Documentation] Update podfile syntax reference on branches and tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

2 participants