Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

After using Open3 from the doc generator, check the exit status. #180

Closed
alloy opened this Issue · 5 comments

2 participants

@alloy
Owner

Currently when appledoc fails, for instance because the templates haven't been installed in ~/Library/Application Support/appledoc, there's no error raised that notifies the user of this.

@fabiopelosin

There is an issue Using popen3 ruby 1.8 don't have a way to know the exit status because double fork is used. Originally I tried to check for the exit status but I desisted for this reason.

Some solutions my be:

  • check if the standard error is empty
  • the POpen4 gem could solve the issue.
@alloy
Owner

Ah crap, that issue again… :) Yeah we should go with popen4 I think.

It’s actually even worse, because iirc the way the double fork works means that child processes can become zombies.

@fabiopelosin fabiopelosin was assigned
@fabiopelosin

Ok I'll take care of it when a decision is taken about #175.

@fabiopelosin

I used popen4.

@alloy
Owner

Sweet.

@fabiopelosin fabiopelosin referenced this issue from a commit
@fabiopelosin fabiopelosin Merge branch 'master' into improved-search
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
  [#112] Refactoring based on suggestions by @alloy
  [#112] Improved remote url detection for spec repo
  [#132, #183] Fix to make repo update tolerant of stray files ~./cocoapods
  [#112] Introduced --push option for setup command
9d87bf4
@fabiopelosin fabiopelosin referenced this issue from a commit
@fabiopelosin fabiopelosin Merge branch 'master' into hidden-setup
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
4ea808d
@fabiopelosin fabiopelosin referenced this issue from a commit
@fabiopelosin fabiopelosin Merge branch 'master' into improved-search
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
  [#112] Refactoring based on suggestions by @alloy
  [#112] Improved remote url detection for spec repo
  [#132, #183] Fix to make repo update tolerant of stray files ~./cocoapods
  [#112] Introduced --push option for setup command
cc00053
@fabiopelosin fabiopelosin referenced this issue from a commit
@fabiopelosin fabiopelosin Merge branch 'master' into hidden-setup
* master:
  [#184] fix for documentation options
  [#180] check appledoc exit status
e6a527b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.