pod spec lint gives unclear error message when https://www.github.com/repo/project.git format is given for source URL

[ikai]

Repro steps:

1. Set the pod spec's source to: = { :git => "https://www.github.com/YOUR-REPO/YOUR-SPEC.git", :tag => "YOUR_TAG" }
2. Run pod lib lint

Expected: a warning that "www" prefix is not required
Observed: This error message:

- WARN  | Github repositories should use `https` link.

This could probably be a bit more clear.

[neonichu]

I think that shouldn't give a warning at all.

[ikai]

If you browse to a github repo using https and the www prefix, GitHub will forward you to the correct URL sans prefix. I think it is okay to be strict here because this is a one second fix for a developer. The tool should just be clear about the expected format.

[neonichu]

@alloy any opinion on this?

[alloy]

I think that in this case it makes sense to also lint the use of a subdomain on GitHub, unless there are other valid subdomains, such as gist that would then require additional handling.

[neonichu]

There's already a special case for gist.github.com, I would propose to just extended that.

BTW, I can't actually reproduce the OP's warning with CocoaPods 0.31.1

[neonichu]

Seems to me that the current behaviour is actually that www.github.com will not be treated as a GitHub URL and the checks for GH will be skipped.

https://github.com/CocoaPods/Core/blob/master/lib/cocoapods-core/specification/linter.rb#L317

I would propose to extend this with www.github.com - @alloy?

[alloy]

@neonichu I think that link is no longer correct, but looking at perform_github_source_checks it should indeed need to be changed. Maybe we should just disallow this after all, it makes everything simpler and saves a redirect to boot.

[neonichu]

Fixed the link. Will tackle this so that www.github.com will be disallowed with an appropriate error message.