Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PODS_TARGET_SRCROOT does not work in user_target_xcconfig. #6440

Open
alloy opened this issue Jan 27, 2017 · 6 comments
Open

PODS_TARGET_SRCROOT does not work in user_target_xcconfig. #6440

alloy opened this issue Jan 27, 2017 · 6 comments
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s2:confirmed Issues that have been confirmed by a CocoaPods contributor t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it

Comments

@alloy
Copy link
Member

alloy commented Jan 27, 2017

Was it a deliberate decision to only make this work in pod_target_xcconfig?

Currently, when trying to use it in user_target_xcconfig, the variable is probably blank and e.g. $(PODS_TARGET_SRCROOT)/ReactCommon expands to /ReactCommon.
@alloy alloy added s1:awaiting input Waiting for input from the original author t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels Jan 27, 2017
@alloy
Copy link
Member Author

alloy commented Jan 27, 2017

This is re the code introduced in #6037.

@alloy alloy mentioned this issue Jan 27, 2017
Closed
@segiddins
Copy link
Member

I don't think its possible to do that, as each pod will have their own value of PODS_TARGET_SRCROOT

@alloy
Copy link
Member Author

alloy commented Jan 28, 2017

Yeah good point, I was thinking about expanding the paths during pod install, but it’s definitely not how it would normally work indeed.

@segiddins
Copy link
Member

An option would be to add PODS_TARGET_SRCROOT_#{POD_NAME}, but that's adding a lot of build settings

@alloy
Copy link
Member Author

alloy commented Jan 28, 2017

Would it really matter? I guess it slows down header lookup slightly, but I doubt by much. Alternatively it could be emitted only when any user_target_xcconfig setting refers to PODS_TARGET_SRCROOT_#{POD_NAME} ?

@dnkoutso
Copy link
Contributor

Will see what I can do.

@endocrimes endocrimes added d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s2:confirmed Issues that have been confirmed by a CocoaPods contributor t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it and removed s1:awaiting input Waiting for input from the original author t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels Jun 18, 2017
@dnkoutso dnkoutso removed their assignment Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
d2:moderate A moderately-difficult ticket that may require a bit of knowledge about the codebase s2:confirmed Issues that have been confirmed by a CocoaPods contributor t1:enhancement Enhancements that have not been picked up yet. Please comment if you plan to work on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alloy @dnkoutso @endocrimes @segiddins