Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing "Remove" messages color .red with .yellow - #1041

Closed
wants to merge 1 commit into from
Closed

Replacing "Remove" messages color .red with .yellow - #1041

wants to merge 1 commit into from

Conversation

seivan
Copy link
Contributor

@seivan seivan commented May 13, 2013

Although (incredibly) superficial it always scares the crap out of me when I see red in my terminal(s). May I suggest a more neutral yellow (notification) instead?

Removed pods are (usually) by design.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 58a09d4 on influitive:feature/removing_in_yellow into ded582e on CocoaPods:master.

@fabiopelosin
Copy link
Member

While consider your point reasonable we prefer to keep the existing implementation as we consider that part of the output a diff. We might change our mind if we get more feedback in support for this change, though. Therefore I'm sorry to close this.

Thanks for the contribution anyway.

jzapater pushed a commit to jzapater/CocoaPods that referenced this pull request Sep 17, 2013
Adding NoticeView 3.0.3 podspec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants