Add visionos as a new platform

[gabrieldonadel]

This PR introduces visionOS as a supported platform. This lays the groundwork for supporting visionOS as a new platform in CocoaPods.

Closes #11961

Related to CocoaPods/Core#745 and CocoaPods/Xcodeproj#913

[gabrieldonadel]

Hi @dnkoutso, can you take a look at this PR? Am I missing something that needs to be addressed here?

[dnkoutso]

@gabrieldonadel can you bundle update cocoapods-core xcodeproj in your PR to bump the SHA's with the recently merged PRs?

[gabrieldonadel]

@gabrieldonadel can you bundle update cocoapods-core xcodeproj in your PR to bump the SHA's with the recently merged PRs?

Sure, I've just pushed a commit updating Gemfile.lock

[gabrieldonadel]

Seems that we'll need to update LastUpgradeVersion = "1500" inside https://github.com/CocoaPods/cocoapods-integration-specs

[dnkoutso]

@gabrieldonadel from the cocoapods repo on your branch run bundle exec rake spec:integration:update it will modify a bunch of files and then open a PR in the integration specs repo. We will merge that and then bump the SHA here.

Its a process but those integration specs catch some stuff...

[gabrieldonadel]

@gabrieldonadel from the cocoapods repo on your branch run bundle exec rake spec:integration:update it will modify a bunch of files and then open a PR in the integration specs repo. We will merge that and then bump the SHA here.

Its a process but those integration specs catch some stuff...

Should I run bundle exec rake spec:integration:update inside the CocoaPods/CocoaPods repo? This gives me an error

[dnkoutso]

@gabrieldonadel might be bundle exec rake spec:rebuild_integration_fixtures sorry.

List is with bundle exec rake spec --tasks

[dnkoutso]

And yes inside CocoaPods/CocoaPods repo and be on your branch.

[gabrieldonadel]

Ohh I see @dnkoutso, this should be fixed now CocoaPods/cocoapods-integration-specs#343

[dnkoutso]

I had one question in CocoaPods/cocoapods-integration-specs#343.

[dnkoutso]

@gabrieldonadel congratulations and thank you so much!

[jerryliurui]

Hi, How could use 1.13 to us visionOS platform?

[NachoSoto]

Was this tested before being released?

pod lib lint --platforms=visionos fails:

• ERROR | [visionOS] unknown: Encountered an unknown error (Could not find a visionos simulator (valid values: ios, tvos, watchos, xros). Ensure that Xcode -> Window -> Devices has at least one visionos simulator listed or otherwise add one.

pod lib lint --platforms=xros fails too:

[!] Unrecognized platform xros. Valid platforms: iOS, macOS, watchOS, visionOS, tvOS

[paulb777]

Do you have a visionos simulator installed in your local Xcode installation?

[NachoSoto]

Xcode 15 beta 8 on CircleCI has it installed, yes: https://discuss.circleci.com/t/xcode-15-rc-released-important-notice-for-visionos-sdk-users/49278#warning-for-visionos-sdk-users-warning-2

The problem is that it's expecting xros:

Could not find a visionos simulator (valid values: ios, tvos, watchos, xros

But the --platforms parameter doesn't accept that.

[dnkoutso]

Ah we might need to update https://github.com/CocoaPods/fourflusher/blob/master/lib/fourflusher/find.rb#L107-L126

different gem which we could update and cocoapods can start functioning

[dnkoutso]

Hmm maybe something is off between the two of them...

[dnkoutso]

The problem is that it's expecting xros:

yeah you are right @NachoSoto

[NachoSoto]

@dnkoutso any update on this?

[denandreychuk]

Experiencing the same problem with pod lib lint. It's expecting xros.

[triplef]

Would be great if pod lib lint support for visionOS could be fixed. Multiple pods such as Firebase and RevenueCat are currently blocked by this to ship their visionOS support. 🙏

[NachoSoto]

FYI this is still broken on CocoaPods 1.15.0:

[!] Unrecognized platform visionOS. Valid platforms: iOS, macOS, watchOS, visionOS, tvOS

[denandreychuk]

It's sad considering vision pro release in a couple of days

[NachoSoto]

I've looked through the code in CocoaPods/Core#745 and I don't fully understand why it doesn't work.

The error comes from here:

@platforms = platforms.map do |platform|
  result =  case platform.to_s.downcase
            # Platform doesn't recognize 'macos' as being the same as 'osx' when initializing
            when 'macos' then Platform.macos
            else Platform.new(platform, nil)
            end
  unless valid_platform?(result)
    raise Informative, "Unrecognized platform `#{platform}`. Valid platforms: #{VALID_PLATFORMS.join(', ')}"
  end
  result
end

This is how valid_platform is implemented:

def valid_platform?(platform)
  VALID_PLATFORMS.any? { |p| p.name == platform.name }
end

Which comes from CocoaPods/Core:

def self.all
  [ios, osx, watchos, visionos, tvos]
end

I see there's logic there for lowercasing the name, but as far as I can tell it's correct.

[amorde]

The lowercasing is only applied to the macos check. Looks like a simple fix - thanks for narrowing it down!