Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CocoaPods: enabled visionOS #3262

Merged
merged 5 commits into from Jan 30, 2024
Merged

CocoaPods: enabled visionOS #3262

merged 5 commits into from Jan 30, 2024

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Oct 2, 2023

Changes:

Fixes https://community.revenuecat.com/sdks-51/how-to-support-visionos-via-cocoapods-3499

@NachoSoto NachoSoto added build Changes that affect the build system xrOS labels Oct 2, 2023
@NachoSoto NachoSoto requested a review from a team October 2, 2023 18:00
@NachoSoto
Copy link
Contributor Author

We might have to bump the jobs to Xcode 15.0, but wanted to see whether this is working for now.

.circleci/config.yml Outdated Show resolved Hide resolved
@NachoSoto NachoSoto force-pushed the cocoapods-visionos branch 2 times, most recently from 6cbb1bb to 0ca4e91 Compare October 2, 2023 20:51
claide (1.0.3)
cocoapods (1.12.1)
claide (1.1.0)
cocoapods (1.13.0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed to update it here too.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update! 👏 Excited to see the addition of visionOS to the deployment targets in the Podspec. Thanks for keeping the Swift version up-to-date and providing clear instructions on the required Xcode version. The integration of the visionOS CocoaPods lint check and the switch to Xcode 15 beta 8 for the CI job make it even better.

However, I noticed the mention of the issue CocoaPods/CocoaPods#11965. Any insights on how this is being addressed or any potential workarounds? Looking forward to the continued progress! 🚀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support for it on CocoaPods is still not working: CocoaPods/CocoaPods#12159 (comment)
We haven't received an update from them, so until then unfortunately we can't release this.

@NachoSoto
Copy link
Contributor Author

Blocked by CocoaPods/CocoaPods#11965 (comment)

NachoSoto added a commit that referenced this pull request Oct 9, 2023
Extracted this from #3262 since that's blocked by CocoaPods.
fastlane/Fastfile Outdated Show resolved Hide resolved
pod_lib_lint(
verbose: true,
podspec:'RevenueCat.podspec',
platforms:"xros",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xcode 15.1 beta 3 changes this to visionos so this will probably have to change too.

@NachoSoto
Copy link
Contributor Author

Reminder that we need to add this to RevenueCatUI too (see #3368)

@NachoSoto NachoSoto force-pushed the cocoapods-visionos branch 4 times, most recently from 2ecb63e to 89ef805 Compare December 6, 2023 21:00
- Added `visionOS` to list of deployment targets in `Podspec`
- Updated `Swift` version to 5.7 (see https://swiftversion.net/), Xcode 14.0 is required, and that's Swift 5.7. We no longer support 5.5
- Added `visionOS` to release checks
.circleci/config.yml Outdated Show resolved Hide resolved
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' }
s.pod_target_xcconfig = {
'DEFINES_MODULE' => 'YES',
'SWIFT_ACTIVE_COMPILATION_CONDITIONS[sdk=xros*]' => '$(inherited) VISION_OS',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new.

@NachoSoto NachoSoto enabled auto-merge (squash) January 30, 2024 01:08
@NachoSoto NachoSoto removed the blocked label Jan 30, 2024
@NachoSoto NachoSoto enabled auto-merge (squash) January 30, 2024 01:08
@NachoSoto NachoSoto merged commit 16a3f9d into main Jan 30, 2024
24 checks passed
@NachoSoto NachoSoto deleted the cocoapods-visionos branch January 30, 2024 01:21
@NachoSoto NachoSoto mentioned this pull request Jan 30, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jan 30, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jan 30, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jan 30, 2024
NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system xrOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants