Fix static binaries check #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| should.raise(Informative) { @installer.install! }.message.should.match /transitive.*libThing/ | ||
| end | ||
|
|
||
| it 'allows transitive static dependencies which contain other source code' do | ||
| Sandbox::FileAccessor.any_instance.stubs(:source_files).returns([Pathname('/yolo.m')]) |
There was a problem hiding this comment.
please be consistent with absolute/relative paths, even in the specs
There was a problem hiding this comment.
Because the install! is actually running further in this spec, it needs to be absolute to not fail. Let's change the other spec to also be absolute?
There was a problem hiding this comment.
sure, just so long as they're consistent.
|
👍 |
neonichu
force-pushed
the
fix-static-binaries-check
branch
2 times, most recently
from
27a899e
to
558103e
Compare
neonichu
force-pushed
the
fix-static-binaries-check
branch
from
558103e
to
dba419f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits our check for static transitive dependencies to those which are known to not work.
Reasoning:
should_build? == falsemeans the static library or framework will be linked directly to the user target=> this kind of dependency cannot be fulfilled if the integration is done via frameworks.
This fixes #3194