Cache globbing in PathList to speed up pod install

[vincentisambart]

I'm not sure if caching paths_for_attribute is wise or not, but in my test it makes pod install on our app much faster: 140 sec → 20 sec. All specs still pass.

It might be problematic if the content on the file system changes during the run, that's why it's more of an experiment that anything else.

What do you think?

[segiddins]

Can we just invalidate when refreshing from the FS? Otherwise, this seems pretty good to me ;)

[vincentisambart]

In fact that's the main problem: I don't see what would be the best place in the code to invalidate the cache.

[segiddins]

Ah, that's in PathList. Maybe the caching would best belong there? (in relative_glob?)

[vincentisambart]

Something like that new commit I just pushed?

(I know I still need to refactor relative_glob because Rubocop complains it's too complex)

[segiddins]

Yup, something just like that!

[vincentisambart]

Do you have an idea why here the code checks if the pattern is a string or not? The documentation of the method says it's supposed to be strings.

[segiddins]

Nope, no clue. That can probably be removed.

[vincentisambart]

Seeing how it's been used it seems it would be for Regexps, but with the specs now being in JSON I guess that doesn't make sense anymore.

[vincentisambart]

I added a CHANGELOG entry and removed handling of regexp patterns.

[neonichu]

Great, let's merge this! Thanks a lot, @vincentisambart 🎉

[alloy]

@vincentisambart Nice work!