Fix Swift code completion for Development Pods #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neonichu ping on this? |
|
Actually, I'm not sure we can safely do this, as won't this make all the added paths absolute instead of relative? Can you double check? |
|
Will do. |
|
Scratch my previous comment, this should work |
|
@neonichu ping on this? |
neonichu
force-pushed
the
use-realpath-for-development-pods
branch
from
acde0c3
to
ca62bcd
Compare
neonichu
added a commit
that referenced
this pull request
Nov 15, 2015
|
👍 |
neonichu
force-pushed
the
use-realpath-for-development-pods
branch
from
ca62bcd
to
67e4aca
Compare
| @@ -179,13 +179,13 @@ def pod_support_files_group(pod_name, dir) | |||
| # @return [PBXFileReference] The new file reference. | |||
| # | |||
| def add_file_reference(absolute_path, group, reflect_file_system_structure = false) | |||
| file_path_name = Pathname.new(absolute_path) | |||
| file_path_name = absolute_path.is_a?(Pathname) ? absolute_path : Pathname.new(absolute_path) | |||
There was a problem hiding this comment.
why is this change necessary?
There was a problem hiding this comment.
It's not really, but it made stubbing things on a specific Pathname instance possible :)
segiddins
added a commit
that referenced
this pull request
Nov 15, 2015
…pods Fix Swift code completion for Development Pods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3777.