[Project] Change config defines to be prefixed #4702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
seg-config-defines
branch
from
452dccd
to
2631403
Compare
| # @return [String] The preprocessor definition to set for the configuration. | ||
| # | ||
| def define_for_build_configuration(name) | ||
| "POD_CONFIGURATION_#{name}".gsub(/[^a-zA-Z0-9_]/, '_').upcase |
There was a problem hiding this comment.
Let's prefix that with .underscore, so that camelcase configuration names will yield to a nicer output.
|
This is a breaking change, please review? |
| # | ||
| # @return [String] The preprocessor definition to set for the configuration. | ||
| # | ||
| def define_for_build_configuration(name) |
There was a problem hiding this comment.
As this method doesn't have any side-effect, I don't think it should be named by the leading verb convention. I'd prefer definition_for_… here.
|
👍 LGTM beside my last comment |
|
LGTM |
segiddins
added a commit
that referenced
this pull request
Dec 30, 2015
[Project] Change config defines to be prefixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4143.
Closes #4148.
\c @mrackwitz