Always update input/output paths even if they are empty #7368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
force-pushed
the
always_update_paths
branch
3 times, most recently
from
7cc25f4
to
d7dde05
Compare
dnkoutso
commented
Jan 25, 2018
| @@ -111,16 +107,12 @@ def remove_embed_frameworks_script_phase_from_target(native_target) | |||
| # | |||
| # @return [void] | |||
| # | |||
| def add_copy_resources_script_phase_to_target(native_target, script_path, input_paths = [], output_paths = []) | |||
| def create_or_update_copy_resources_script_phase_to_target(native_target, script_path, input_paths = [], output_paths = []) | |||
There was a problem hiding this comment.
just renamed method to match better what it actually does.
dnkoutso
commented
Jan 25, 2018
| @@ -71,15 +71,11 @@ class << self | |||
| # | |||
| # @return [void] | |||
| # | |||
| def add_embed_frameworks_script_phase_to_target(native_target, script_path, input_paths = [], output_paths = []) | |||
| def create_or_update_embed_frameworks_script_phase_to_target(native_target, script_path, input_paths = [], output_paths = []) | |||
There was a problem hiding this comment.
just renamed method to match better what it actually does.
dnkoutso
force-pushed
the
always_update_paths
branch
from
d7dde05
to
efecc32
Compare
dnkoutso
force-pushed
the
always_update_paths
branch
from
efecc32
to
847d7a4
Compare
segiddins
approved these changes
Jan 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a case in which a pod input/output path was added but then it does not get removed if the input/output paths are now empty.
This can also occur if someone uses
use_frameworks!and switches out to static libs.