[Analyzer] Allow calling #generate_version_locking_dependencies witho… #7924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut a sandbox set up
Here's an example of your CHANGELOG entry: * [Analyzer] Allow calling #generate_version_locking_dependencies witho…
[segiddins](https://github.com/segiddins)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
dnkoutso
reviewed
Jul 11, 2018
| @@ -185,6 +185,10 @@ def update_mode | |||
| end | |||
| end | |||
|
|
|||
| def podfile_dependencies | |||
There was a problem hiding this comment.
is this public? does it it need to be?
There was a problem hiding this comment.
nope, it's private and can stay that way
dnkoutso
reviewed
Jul 11, 2018
| pods_to_unlock = local_pod_names.to_set.delete_if do |pod_name| | ||
| sandbox.specification(pod_name).checksum == lockfile.checksum(pod_name) | ||
| next unless sandbox_specification = sandbox.specification(pod_name) |
There was a problem hiding this comment.
does this fix something else?
There was a problem hiding this comment.
oh nm I think this can fix a crasher.
There was a problem hiding this comment.
yeah, this is the actual fix, the other change is just to allow testing it
dnkoutso
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ut a sandbox set up