Use maximally-compatible launch storyboard for iOS 8 compatibility. #8286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SlaunchaMan yes lets pass deployment target and rename |
|
Sounds good. How do I go about updating |
|
@SlaunchaMan you will probably be OK if you split the two because the integration specs will use iOS 9.0 if they don't I will provide instructions, its fairly easy. |
|
@SlaunchaMan make sure the |
|
@dnkoutso Xcode doesn’t ask you for your deployment target before you create a project, but what I have here is the minimal set of changes that make it build successfully. |
dnkoutso
approved these changes
Nov 16, 2018
segiddins
approved these changes
Nov 16, 2018
paulb777
pushed a commit
that referenced
this pull request
Dec 20, 2018
Use maximally-compatible launch storyboard for iOS 8 compatibility.
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
Release 1.6.0.rc.1 * tag '1.6.0.rc.1': Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
dnkoutso
added a commit
that referenced
this pull request
Jan 25, 2019
* 1-6-stable: [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request #8334 from CocoaPods/paulb777/ldflags-regression (#8429) Merge pull request #8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (#8428) Merge pull request #8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request #8287 from CocoaPods/paulb777/sf-info-plist Merge pull request #8234 from colus001/master Fix merge Merge pull request #8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request #8196 from cfis/master [CHANGELOG] Add empty Master section
sebastianv1
added a commit
to sebastianv1/CocoaPods
that referenced
this pull request
Jan 29, 2019
* upstream/master: (21 commits) Clean up `uses_swift?` method Fix `add_cdn_spec` with latest cocoapods-core bump [CHANGELOG] Add entry for plural setting [BuildSettings] Mark USER_HEADER_SEARCH_PATHS as plural [CHANGELOG] Add empty Master section Release 1.6.0.rc.1 [Gemspec] Bump Xcodeproj to `'>= 1.8.0', '< 2.0'` Bundle update Point Core at the stable branch Fix CHANGELOG for 1-6-stable Merge pull request CocoaPods#8334 from CocoaPods/paulb777/ldflags-regression (CocoaPods#8429) Merge pull request CocoaPods#8314 from CocoaPods/segiddins/remove-linker-flags-from-pod-targets (CocoaPods#8428) Merge pull request CocoaPods#8291 from CocoaPods/amorde/xcode-10-64-bit Fix unit test for pre build_type implementation Merge pull request CocoaPods#8287 from CocoaPods/paulb777/sf-info-plist Merge pull request CocoaPods#8234 from colus001/master Fix merge Merge pull request CocoaPods#8286 from SlaunchaMan/ios-8-launch-storyboards Supporting Xcode 10.1 with fourflusher 2.1.0. Merge pull request CocoaPods#8196 from cfis/master ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8285. This PR modifies the template for launch storyboards to be compatible with iOS 8 by not including safe area insets.
If we want to keep the current state, it looks like we could pass the deployment target to the method that uses this, so I could create an alternative version that works for iOS 8 targets, keeping this version for iOS 9 targets.