improved hash and yaml output of a target definition #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # and :for_pods key for inhibiting warnings per pod | ||
| # | ||
| def inhibit_warnings_hash | ||
| get_hash_value('inhibit_warnings', { 'all' => false, 'for_pods' => [] }) |
There was a problem hiding this comment.
The class tries to remove the keys when they are false to keep the YAML clean. In this case, would using the following default work:
{}And then in the methods do something like:
def inhibit_warnings_for_pod(pod_name)
inhibit_warnings_hash['for_pods'] ||= []
inhibit_warnings_hash['for_pods'] << pod_name
end
|
Lol… missed your comment… I prefer not to have the keys which are empty or false so the YAML Podfiles stay clean. |
|
yep. makes sense |
supermarin
pushed a commit
that referenced
this pull request
Apr 6, 2013
improved hash and yaml output of a target definition
Ashton-W
pushed a commit
to Ashton-W/Core
that referenced
this pull request
Nov 2, 2015
improved hash and yaml output of a target definition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.