Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how the fuzzy version indicator works #17

Merged
merged 1 commit into from
Apr 17, 2013
Merged

Conversation

pnc
Copy link
Contributor

@pnc pnc commented Apr 17, 2013

Include an example inspired by (but not copied from) the RubyGems documentation and this blog post.

Include an example inspired by (but not copied from) the RubyGems documentation and this blog post: http://blog.zenspider.com/blog/2008/10/rubygems-how-to-preventing-catastrophe.html
@pnc
Copy link
Contributor Author

pnc commented Apr 17, 2013

For context, it appears RubyGems made this same change: rubygems/rubygems#124

@alloy
Copy link
Member

alloy commented Apr 17, 2013

Thanks!

Btw, did you grep the full source to check if we used the ‘spermy’ name elsewhere?

alloy added a commit that referenced this pull request Apr 17, 2013
Clarify how the fuzzy version indicator works
@alloy alloy merged commit e3f3b14 into CocoaPods:master Apr 17, 2013
@pnc
Copy link
Contributor Author

pnc commented Apr 17, 2013

@alloy It only seems to show up in the vendored version of RubyGems (in vendor/version.rb.) Is the vendored version pretty old? This was changed in the above pull request about a year ago.

@pnc pnc deleted the patch-1 branch April 17, 2013 18:17
@coveralls
Copy link

Coverage Status

Coverage increased (+0.35%) when pulling f896f74 on pnc:patch-1 into 05bc268 on CocoaPods:master.

@alloy
Copy link
Member

alloy commented Apr 17, 2013

@pnc Cool. The vendored version is the minimum version of RubyGems that contains all the code/fixes we need, so it might easily be older than a year, but I haven’t double-checked.

Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Clarify how the fuzzy version indicator works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants