-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dependency] Fix obsolete HEAD string check for lockfile entries #293
Conversation
@manuyavuz have an example? In my testing, the version but was always just |
Yes, for the following podfile:
I was having the Podfile.lock as such:
|
And here is the trace of the crash that I took:
|
@segiddins any update on this? |
@@ -350,7 +350,7 @@ def self.from_string(string) | |||
version = match_data[2] | |||
version = version.gsub(/[()]/, '') if version | |||
case version | |||
when ' HEAD' | |||
when /HEAD/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ HEAD( \(based on #{Pod::Version::VERSION_PATTERN}\))?/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Legit.
This is needed to handle cases like `HEAD based on 1.0.5` string specifiers.
21a2080
to
3d6fe79
Compare
@manuyavuz 👍 with a CHANGELOG entry |
…HEAD info and version info
…HEAD [Dependency] Fix obsolete HEAD string check for lockfile entries
Fixes #291.
This check was failing for lockfile entries like
Expecta (HEAD based on 1.0.5)
. We should if entry actually includesHEAD