Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linter] Allow version 0 to be used. #657

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

alloy
Copy link
Member

@alloy alloy commented Oct 22, 2020

In React and React Native, nightly builds are created using a version like 0.0.0-githash. Trying to install such versions with CocoaPods currently fails due to this linter check.

I wasn't able to find a rationale for not allowing version 0 nor could I come up with a reason for not allowing it.

See:

Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me. They'd be weird if they were pushed to the specs repo, but this is a common enough pattern for nightly things that we should probably allow it

CHANGELOG.md Outdated Show resolved Hide resolved
@dnkoutso dnkoutso merged commit 4e5a709 into master Oct 22, 2020
@dnkoutso dnkoutso deleted the allow-version-0-to-be-used branch October 22, 2020 17:19
@dnkoutso dnkoutso added this to the 1.11.0 milestone Oct 22, 2020
@brunolemos
Copy link

brunolemos commented Nov 20, 2020

Could we have a 1.11.0 RC or similar? Thank you.

EDIT: For now I applied this patch locally and it works. The folder can be found by running gem which cocoapods-core.

@alloy
Copy link
Member Author

alloy commented Nov 20, 2020

@brunolemos I assume you’re asking because it allows nightly builds of React Native to be installed? (Just adding some context.)

@brunolemos
Copy link

yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants