-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for readme and changelog pod attributes #658
Add support for readme and changelog pod attributes #658
Conversation
Fix for #661. |
@dnkoutso Would it be appropriate to add retarget this to 1-10-stable so binary pod publishers could get their CocoaPods web pages fixed sooner? |
Would you rebase to 1-10-stable so this can go into 1.10.2? |
8f969f3
to
4a85fe4
Compare
4a85fe4
to
5fbb340
Compare
Done with the rebase. |
Should probably get a changelog entry. Could potentially call this 1.11.0 tbh...but it can be considered a "bug fix" |
Definitely a bug from a binary pod publisher perspective. |
I can add an entry to the CHANGELOG.md file, just let me know which section. |
@jrullman its OK I will merge as is. |
This change adds support and documentation for new optional
readme
andchangelog
attributes, which contain URLs pointing to Markdown files. The CocoaPods Metadata Service has already been modified to read these attributes and, if present, download the files and save them for rendering on the pod page (see CocoaPods/cocoapods-metadata-service#6 and CocoaPods/cocoapods-metadata-service#20).