Add support for readme and changelog pod attributes #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for #661. |
paulb777
approved these changes
Nov 19, 2020
|
@dnkoutso Would it be appropriate to add retarget this to 1-10-stable so binary pod publishers could get their CocoaPods web pages fixed sooner? |
|
Would you rebase to 1-10-stable so this can go into 1.10.2? |
jrullman
force-pushed
the
add_readme_and_changelog
branch
from
8f969f3
to
4a85fe4
Compare
jrullman
force-pushed
the
add_readme_and_changelog
branch
from
4a85fe4
to
5fbb340
Compare
|
Done with the rebase. |
|
Should probably get a changelog entry. Could potentially call this 1.11.0 tbh...but it can be considered a "bug fix" |
|
Definitely a bug from a binary pod publisher perspective. |
|
I can add an entry to the CHANGELOG.md file, just let me know which section. |
|
@jrullman its OK I will merge as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support and documentation for new optional
readmeandchangelogattributes, which contain URLs pointing to Markdown files. The CocoaPods Metadata Service has already been modified to read these attributes and, if present, download the files and save them for rendering on the pod page (see CocoaPods/cocoapods-metadata-service#6 and CocoaPods/cocoapods-metadata-service#20).