Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple rake tasks fails because "shared" repo is considered to be a gem #14

Closed
AliSoftware opened this issue May 15, 2014 · 3 comments

Comments

@AliSoftware
Copy link
Contributor

There is two errors in this issue:

  1. Ruby NameError on line 533:
def spec(gem_dir)
  files = Dir.glob("#{gem_dir}/*.gemspec")
  unless files.count == 1
    error("Unable to select a gemspec #{spec_file}")
  end
  spec_path = files.first
  spec = Gem::Specification::load(spec_path.to_s)
end

The spec_file variable is undefined, leading to Rake aborting with a NameError.


  1. After changing #{spec_file} to #{gem_dir} so that ruby stops crashing, I can see that the error(...) line occurs when dealing with the CocoaPods/shared repo.
  • either shared.gemspec is missing and should be added in the shared repo
  • or that the shared repo should not be included in the GEM_REPOS array
  • or that local_dependencies_[un]set tasks should use a different array than GEM_REPOS

/cc @irrationalfab

@AliSoftware
Copy link
Contributor Author

Seems to have a similar issue with rake bootstrap failing with the shared repo because it is expecting to have a gemspec.

Bootstrapping shared/
rake aborted!
Unable to determine name from existing gemspec. Use :name => 'gemname' in #install_tasks to manually set it.

@AliSoftware AliSoftware changed the title "rake local_dependencies_[un]set" fails because "shared.gemspec" missing multiple rake tasks fails because they expect "shared" to be have gemspec May 16, 2014
@AliSoftware
Copy link
Contributor Author

As shared is not a gem, we should definitely remove shared from the GEM_REPOS array.

But then should we add it in another array of the Rakefile like DEFAULT_REPOS, so that it is cloned anyway? (not sure to master all the implications as the Rainforest's Rakefile is rather large)

@AliSoftware AliSoftware changed the title multiple rake tasks fails because they expect "shared" to be have gemspec multiple rake tasks fails because "shared" repo is considered to be a gem May 16, 2014
AliSoftware added a commit that referenced this issue May 16, 2014
Fix NameError exception (see #14).
@AliSoftware
Copy link
Contributor Author

fixed by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant