Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ThumbnailService podspec #10867

Merged
merged 3 commits into from Apr 23, 2014
Merged

Added ThumbnailService podspec #10867

merged 3 commits into from Apr 23, 2014

Conversation

alexgarbarev
Copy link
Contributor

No description provided.

@squarefrog
Copy link
Contributor

ThumbnailService/1.0.0/ThumbnailService.podspec [Full]
 -> ThumbnailService (1.0.0)
    - ERROR | Missing required attribute `homepage`.
    - WARN  | The summary should be a short version of `description` (max 140 characters).
    - NOTE  | [xcodebuild]  ThumbnailService/ThumbnailService/ThumbnailService/Operations/TSRequestedOperation.m:116:26: warning: implicit conversion from enumeration type 'TSRequestQueuePriority' (aka 'enum TSRequestQueuePriority') to different enumeration type 'NSOperationQueuePriority' (aka 'enum NSOperationQueuePriority') [-Wenum-conversion]
    - NOTE  | [iOS] [xcodebuild]  ThumbnailService/ThumbnailService/ThumbnailService/Sources/TSSourceImage.m:29:55: warning: values of type 'NSUInteger' should not be used as format arguments; add an explicit cast to 'unsigned long' instead [-Wformat]
    - NOTE  | [iOS] [xcodebuild]  ThumbnailService/ThumbnailService/ThumbnailService/Sources/TSSourceVideo.m:31:58: warning: values of type 'NSUInteger' should not be used as format arguments; add an explicit cast to 'unsigned long' instead [-Wformat]
    - WARN  | [iOS] Unable to find a license file
 -> The spec cannot be accepted.

You need to set the homepage, and license properties. Also summary can be a maximum of 140 characters.

@alexgarbarev
Copy link
Contributor Author

  • added homepage attribute
  • code pass "-Wextra -Werror -pedantic" warnings
  • added license file
  • change summary
  • added description

kylef added a commit that referenced this pull request Apr 23, 2014
Added ThumbnailService podspec
@kylef kylef merged commit fdf4faf into CocoaPods:master Apr 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants