Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebContentView v1.0.4 by @nicklockwood. #131

Merged
merged 1 commit into from Apr 21, 2012
Merged

Add WebContentView v1.0.4 by @nicklockwood. #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions WebContentView/1.0.4/WebContentView.podspec
View file
Open in desktop
@@ -0,0 +1,10 @@
Pod::Spec.new do |s|
s.name = 'WebContentView'
s.version = '1.0.4'
s.summary = 'WebContentView provides a simple native interface for rendering rich HTML content in an iPhone app using a UIWebView. It is not designed to work as a embedded web browser for on or offline content, it doesn\'t load URLs - think of it more as a "rich" version of the UITextView, where content can be set using HTML instead of plain text.'
s.homepage = 'http://charcoaldesign.co.uk/source/cocoa#webcontentview'
s.author = 'Nick Lockwood'
s.source = { :git => 'git://github.com/nicklockwood/WebContentView.git', :tag => '1.0.3' }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tag version should be the same as the pod version. There is no 1.0.4 tag, though, so either the file should be renamed, or the tag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's my bad. I tried to contact the project author to check if he forgot to push version tag, and will update the this podspec later.
fyi: nicklockwood/WebContentView#1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 88e3a85.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I see he now added the 1.0.4 tag and even a newer 1.1 one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added 1.1 to specs now. (ref. 73260d2)

s.source_files = 'WebContentView/WebContentView.{h,m}'
s.clean_paths = 'WebContentViewExample', 'WebContentViewExample.xcodeproj'
end