Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwUI: Add pod for released versions 0.1-0.4 #378

Merged
merged 3 commits into from
Aug 7, 2012
Merged

TwUI: Add pod for released versions 0.1-0.4 #378

merged 3 commits into from
Aug 7, 2012

Conversation

jerolimov
Copy link
Contributor

And drop support for random commit version 0.0.1!

Current (and now removed) version 0.0.1 points to this "random" (?) commit:

I've added release versions for 0.1 - 0.4 to two matching commit refs and two tags:

@travisbot
Copy link

This pull request passes (merged 123a0f9 into c51614d).

@fabiopelosin
Copy link
Member

And drop support for random commit version 0.0.1!

When a library is unversioned and somebody wants to add it to CocoaPods it uses the lasted reference and marks it as 0.0.1.

Please don't remove existing versions because we want a podfile to be as much reliable as possible (we want pod install give a Podfile and a Podfile.lock to produce the same results across different machines and time... we are not there yet). Although 0.0.1 might be an exception as it is unlikely that somebody requires them explicitly and they could be deleted but I think that this should be done after we create an issue a have a proper discussion about it.

Regarding 0.3 it points to a commit, but it should be a tag.

@travisbot
Copy link

This pull request passes (merged 753c886 into c51614d).

@jerolimov
Copy link
Contributor Author

Fix v0.3

I think restoring v0.0.1 is not required because any user knows that a 0.0.1 is a unreleased version. So it works with ~> 0.0.1 and it clears that now (and in any future) the TwUI specs contains only releases.

Currently the 0.0.1 spec is anywhere between 0.2 and 0.3 and this doesn't show the version number which is imho more crappy than a removed version which requires (some few, if any) to update their (imho broken) dependency to .. i don't know ... the older 0.2 or the newer 0.3?

@fabiopelosin
Copy link
Member

I think restoring v0.0.1 is not required because any user knows that a 0.0.1 is a unreleased version. So it works with ~> 0.0.1 and it clears that now (and in any future) the TwUI specs contains only releases.

One day we'll have to manage with outdated podspecs (move to separate repo?). In the meanwhile we usually keep them in order to not break existing podfiles.

Currently the 0.0.1 spec is anywhere between 0.2 and 0.3 and this doesn't show the version number which is imho more crappy than a removed version which requires (some few, if any) to update their (imho broken) dependency to .. i don't know ... the older 0.2 or the newer 0.3?

I didn't know about the inconsistency in this case I agree that it is better to remove it. I'm merging!

fabiopelosin added a commit that referenced this pull request Aug 7, 2012
TwUI: Add pod for released versions 0.1-0.4
@fabiopelosin fabiopelosin merged commit 0632373 into CocoaPods:master Aug 7, 2012
fabiopelosin added a commit that referenced this pull request Jan 29, 2014
TwUI: Add pod for released versions 0.1-0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants