Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ready for Xcode 7.0 #271

Merged
merged 6 commits into from
Jun 25, 2015
Merged

Get ready for Xcode 7.0 #271

merged 6 commits into from
Jun 25, 2015

Conversation

mrackwitz
Copy link
Member

  • Add build setting ENABLE_TESTABILITY
  • Add constant for new LastSwiftUpdateCheck
  • Bump last known version
  • Handle PRODUCT_BUNDLE_IDENTIFIER?

@segiddins
Copy link
Member

Let's get the tests passing so we can merge this?

segiddins
segiddins reviewed Jun 19, 2015
View reviewed changes
lib/xcodeproj/constants.rb
@@ -25,6 +25,10 @@ module Constants
#
LAST_UPGRADE_CHECK = '0640'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 0700?

@segiddins
Copy link
Member

PRODUCT_BUNDLE_IDENTIFIER should be in COMMON_BUILD_SETTINGS => :all ?

@mrackwitz
Copy link
Member Author

@segiddins: But PRODUCT_BUNDLE_IDENTIFIER contains a custom value related to the target name, doesn't it?

@segiddins
Copy link
Member

Dammit, yeah, it defaults to PRODUCT_BUNDLE_IDENTIFIER = "org.name.${PRODUCT_NAME:rfc1034identifier}";

@segiddins
Copy link
Member

👍

@kylef
Copy link
Contributor

kylef commented Jun 25, 2015

👌

neonichu added a commit that referenced this pull request Jun 25, 2015
@neonichu
Merge pull request #271 from CocoaPods/mr-xcode-7.0
8cf8e0f 
[WIP] Get ready for Xcode 7.0
@neonichu neonichu merged commit 8cf8e0f into master Jun 25, 2015
@neonichu neonichu deleted the mr-xcode-7.0 branch June 25, 2015 23:19
@neonichu neonichu changed the title [WIP] Get ready for Xcode 7.0 Get ready for Xcode 7.0 Jun 25, 2015
neonichu added a commit that referenced this pull request Jun 25, 2015
@neonichu
Added beta remark to Changelog entry for #271
fc53251
@mrackwitz
Copy link
Member Author

thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mrackwitz @segiddins @kylef @neonichu