Support embedded workspace parsing issue 605 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnkoutso
reviewed
Sep 5, 2018
| @@ -73,6 +73,8 @@ def absolute_path(workspace_dir_path) | |||
| File.expand_path(File.join(workspace_dir_path, path)) | |||
| when 'container' | |||
| File.expand_path(File.join(workspace_dir_path, path)) | |||
| when 'self' | |||
There was a problem hiding this comment.
nit: we can potentially combine all of these cases since they all return the same.
There was a problem hiding this comment.
Good point, I was trying to change the minimum. Should I combine the first three cases as a multi-value case? I tried this locally and tests pass
workspace_dir_path = workspace_dir_path.to_s
case type
when 'group', 'container', 'self'
File.expand_path(File.join(workspace_dir_path, path))
when 'absolute'
File.expand_path(path)
when 'developer'
raise "Developer workspace file reference type is not yet supported (#{path})"
else
raise "Unsupported workspace file reference type `#{type}`"
end
end
dnkoutso
approved these changes
Sep 5, 2018
|
@LizCira one tiny nit, can you squash to a single commit? |
LizCira
force-pushed
the
support-embedded-workspace-parsing-issue-605
branch
from
ce7f557
to
e726a4b
Compare
4 tasks
|
thank you! |
|
My first open source contribution, thank you for being so helpful and prompt about handling it! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as discussed in Issue 605 (#605) here's a proposed fix and associated test for an error encountered when trying to parse Xcode projects that make use of the embedded workspace structure.
closes #605