Add fallback to sort group by full path #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amazing! |
|
Still would love a test here perhaps, merging. |
igor-makarov
added a commit
to igor-makarov/Xcodeproj
that referenced
this pull request
Jul 14, 2021
Merged
igor-makarov
added a commit
to igor-makarov/Xcodeproj
that referenced
this pull request
Jul 14, 2021
igor-makarov
added a commit
to igor-makarov/Xcodeproj
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where having several items that have the same
basenameandextnamewould be sorted in an unstable manner.Example:
Because essentially all of these files have the same
basenameandextname, the sort becomes non-deterministic.Adding a fallback by full path, eg.g
en.lproj/InfoPlist.stringsresolves this.