Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an unambiguous sort order to build phase files #839

Merged
merged 2 commits into from
Jul 18, 2021

Conversation

igor-makarov
Copy link
Contributor

@igor-makarov igor-makarov commented Jul 16, 2021

This PR resolves an issue where build files of the same build phase sharing the same filename were being treated as equal by the sort algorithm. This resulted in an unstable sort order.

The PR introduces a defined sort order for build files that aims to remove almost all ambiguity:

  • Sort by display base name, lowercased
  • If ambiguous, sort by display name, lowercased
  • If ambiguous, sort by full path, lowercased

To be clear - before the PR, the build files were being sorted by the default sort impl in AbstractObject.

Copy link
Member

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Changelog entry?

@igor-makarov
Copy link
Contributor Author

Yeah, turns out I forgot to add one for the previous PR too! Added both now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants