Add an unambiguous sort order to build phase files #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-makarov
force-pushed
the
sort-build-phase
branch
from
2f1d475
to
26745f5
Compare
igor-makarov
force-pushed
the
sort-build-phase
branch
from
26745f5
to
2345623
Compare
|
Yeah, turns out I forgot to add one for the previous PR too! Added both now. |
dnkoutso
approved these changes
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves an issue where build files of the same build phase sharing the same filename were being treated as equal by the sort algorithm. This resulted in an unstable sort order.
The PR introduces a defined sort order for build files that aims to remove almost all ambiguity:
To be clear - before the PR, the build files were being sorted by the default sort impl in
AbstractObject.