Refactor XCScheme API to enable multiple targets #95
Conversation
|
Changes Unknown when pulling ffbb9ef on jasonprado:master into * on CocoaPods:master*. |
|
|
||
| if (build_target.product_type == 'com.apple.product-type.application') then | ||
| buildable_product_runnable = profile_action.add_element 'BuildableProductRunnable' | ||
| if build_target.product_type == 'com.apple.product-type.application' then |
There was a problem hiding this comment.
Can you reuse the constant PRODUCT_TYPE_UTI[:application] here?
|
Ruby-wise this looks very good! We follow SemVer and as we’re still pre v1, API breaking changes may be introduced. As I/we haven’t used the scheme code for anything yet, I would like to ask @heyzooi to inspect the API changes and see if he’s missing anything, as he is probably using it in a real-world script/app. @heyzooi Can you take a look at that? |
|
Sure! I will take a look and answer as soon as I can. |
|
I needed to toy around with the Schemes implementation and the patch looked good! I've also added some other minor improvements. Glad to see that the support for the schemes is maturing 🍻 |
|
Looks fine for me. The only feature that I needed was share a scheme. |
|
@heyzooi Thanks! |
This is my first time writing Ruby, so please let me know if I've done anything that's not idiomatic. Also this is a breaking API change, let me know if there's a way to handle that.
With the changes to the API, all existing specs still pass. I added a spec for a project that explicitly builds and tests multiple targets.
Thanks!